Skip to content

Fix firewalld config change in cleanup role #3487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
danpawlik merged 1 commit into from
Nov 18, 2025
Merged

Fix firewalld config change in cleanup role #3487

danpawlik merged 1 commit into from
Nov 18, 2025

Conversation

@cschwede
Copy link
Contributor

@cschwede cschwede commented Nov 17, 2025

Disabling masquerade (or performing any other firewalld change) will fail if firewalld is not yet started when running the cleanup job. This patch ensures firewalld is enabled and started before.

2025-11-17 10:07:56.579272 | controller | Monday 17 November 2025  10:07:56 +0000 (0:00:00.070)       0:00:18.176 *******
2025-11-17 10:07:56.579279 | controller | Monday 17 November 2025  10:07:56 +0000 (0:00:00.070)       0:00:18.174 *******
2025-11-17 10:07:57.259026 | controller | task path: /home/zuul/src/github.com/openstack-k8s-operators/ci-framework/roles/libvirt_manager/tasks/clean_layout.yml:194
2025-11-17 10:07:57.259061 | controller | fatal: [hypervisor]: FAILED! =>
2025-11-17 10:07:57.259068 | controller |     changed: false
2025-11-17 10:07:57.259073 | controller |     msg: firewall is not currently running, unable to perform immediate actions without
2025-11-17 10:07:57.259078 | controller |       a running firewall daemon
2025-11-17 10:07:57.259083 | controller |
2025-11-17 10:07:57.259088 | controller | NO MORE HOSTS LEFT *************************************************************```

@cschwede cschwede requested a review from a team as a code owner November 17, 2025 10:25
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 17, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

danpawlik
danpawlik reviewed Nov 17, 2025
View reviewed changes
@cschwede
[libvirt_manager] Fix firewalld config change in cleanup task
cb192cf 
Disabling masquerade (or performing any other firewalld change) will
fail if firewalld is not yet started when running the cleanup job. This
patch ensures firewalld is enabled and started before.

Signed-off-by: Christian Schwede <[email protected]>
@cschwede cschwede force-pushed the fix-start-firewalld branch from 70a0cb7 to cb192cf Compare November 17, 2025 12:43
@softwarefactory-project-zuul
Copy link

softwarefactory-project-zuul bot commented Nov 17, 2025

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/66b3d01972df4dfaa9543de26baa948d

❌ openstack-k8s-operators-content-provider FAILURE in 7m 51s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
✔️ cifmw-pod-zuul-files SUCCESS in 4m 34s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 31s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 48s
✔️ build-push-container-cifmw-client SUCCESS in 19m 14s
✔️ cifmw-molecule-libvirt_manager SUCCESS in 38m 06s
✔️ cifmw-molecule-reproducer SUCCESS in 14m 30s

@cschwede
Copy link
Contributor Author

cschwede commented Nov 17, 2025

recheck

- 'go: github.com/gophercloud/gophercloud/[email protected]: read "[https://proxy.golang.org/github.com/gophercloud/gophercloud/v2/@v/v2.8.0.zip":](https://proxy.golang.org/github.com/gophercloud/gophercloud/v2/@v/v2.8.0.zip%22:)
      stream error: stream ID 1989; INTERNAL_ERROR; received from peer'
    - 'Error: building at STEP "RUN if [ ! -f $CACHITO_ENV_FILE ]; then go mod download
      ; fi": while running runtime: exit status 1'

@danpawlik danpawlik merged commit bb65d42 into openstack-k8s-operators:main Nov 18, 2025
6 checks passed
@cschwede cschwede deleted the fix-start-firewalld branch November 20, 2025 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danpawlik danpawlik danpawlik approved these changes

@michburk michburk michburk approved these changes

Assignees

No one assigned

Labels

Ready For Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cschwede @danpawlik @michburk